Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): hash npm projects based on version #6879

Merged
merged 1 commit into from Aug 27, 2021

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Npm projects were being hashed like workspace projects which errored when trying to selectively remove other projects from the tsconfig

Expected Behavior

Npm projects are hashed differently from workspace projects. They are hashed via their version.

Related Issue(s)

Fixes #6878

@vercel
Copy link

vercel bot commented Aug 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/AQSBLzjeff3DU65h2no7KJywgfHH
✅ Preview: Canceled

[Deployment for fe3b009 canceled]

@FrozenPandaz FrozenPandaz merged commit 677e481 into nrwl:master Aug 27, 2021
@wrslatz
Copy link
Contributor

wrslatz commented Aug 27, 2021

That was fast 😅 y'all are awesome! 🚀

ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selectivelyHashTsConfig causes Nx commands to fail with Cannot read property 'root' of undefined error
2 participants