Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use defaultConfiguration in run-many and affected when no configuration is specified #6884

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

When having a project with say "defaultConfiguration": "production" configured and running nx build project-name, it will apply the default configuration and run nx run project-name:build:production. This is the expected behavior and if we run nx build project-name multiple times without any changes, it will use the cache as expected.

However, if we run nx run-many --target=build --projects=project-name it misses the cache because it runs nx run project-name:build without the default configuration. The same happens when running nx affected:build (being project-name affected), it misses the cache because it doesn't use the configured default configuration.

Expected Behavior

Using run-many or affected:* commands without specifying the configuration should use the defaultConfiguration if provided.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez added the scope: core core nx functionality label Aug 28, 2021
@leosvelperez leosvelperez self-assigned this Aug 28, 2021
@vercel
Copy link

vercel bot commented Aug 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/A74PxqJJYMg1Lja3r7mZBHDx5cFP
✅ Preview: Canceled

@leosvelperez leosvelperez merged commit bdd01ed into nrwl:master Aug 28, 2021
@leosvelperez leosvelperez deleted the fix-run-multiple-targets-cache-miss branch August 28, 2021 17:07
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant