Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): disable eslint react/display-name rule when using styled-component in nextjs for non-component code #6903

Merged
merged 1 commit into from Aug 31, 2021

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 31, 2021

The CustomDocument component is failing linting now and this fixes it.

@vercel
Copy link

vercel bot commented Aug 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CuQBZqH236UHpwyZRARj7hzFErhZ
✅ Preview: Canceled

[Deployment for eda07c9 canceled]

@jaysoo jaysoo changed the title fix(nextjs): add displayName to CustomDocument component when using s… fix(nextjs): add displayName to CustomDocument component when using styled-components Aug 31, 2021
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed CI

@jaysoo jaysoo force-pushed the fix-nextjs-display-name-lint-issue branch from 73afbea to 7deb524 Compare August 31, 2021 13:53
@jaysoo jaysoo changed the title fix(nextjs): add displayName to CustomDocument component when using styled-components fix(nextjs): disable eslint react/display-name rule when using styled-component in nextjs for non-component code Aug 31, 2021
@jaysoo jaysoo force-pushed the fix-nextjs-display-name-lint-issue branch from 7deb524 to eda07c9 Compare August 31, 2021 14:45
@jaysoo jaysoo merged commit 44db568 into nrwl:master Aug 31, 2021
@jaysoo jaysoo deleted the fix-nextjs-display-name-lint-issue branch August 31, 2021 15:42
sumitparakh pushed a commit to sumitparakh/nx that referenced this pull request Sep 1, 2021
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants