Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fixing application generator when using protractor #7603

Merged
merged 4 commits into from Nov 10, 2021

Conversation

ashley-hunter
Copy link
Contributor

@ashley-hunter ashley-hunter commented Nov 3, 2021

Current Behavior

When generating a new Angular application in an empty workspace (using v2 workspace.json format and standaloneConfig=true) the project fails to generate:

nx generate @nrwl/angular:application --name=sample --e2eTestRunner=protractor --standaloneConfig

This throws the following error:

Cannot find configuration for 'sample-e2e' in /workspace.json.

The issue seems to be that it tries to convert the project to use a standalone config before the e2e project has been created. This seems to be a duplicated step as this happens again in the same generator (after the e2e project has been created):

image

Expected Behavior

The project should generate successfully.

@vercel
Copy link

vercel bot commented Nov 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CecLYbdqckdG6TA7Hc3VkrpQcKUc
✅ Preview: Canceled

[Deployment for f791369 canceled]

@ashley-hunter ashley-hunter marked this pull request as ready for review November 3, 2021 23:32
@AgentEnder
Copy link
Member

LGTM 🎉

@AgentEnder AgentEnder merged commit 8f20571 into nrwl:master Nov 10, 2021
@ashley-hunter ashley-hunter deleted the ng-protractor-fix branch November 10, 2021 17:33
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants