Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): install missing react-test-renderer dependency #7675

Merged
merged 1 commit into from Nov 10, 2021

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

Currently when you install @nrwl/react you don't get react-test-renderer which is divergent from the official documentation.

Expected Behavior

react-test-renderer is also installed as per official react documentation.

Related Issue(s)

Fixes #7578

@vercel
Copy link

vercel bot commented Nov 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/xdv32rJPCTQVPBQDg9WPqTwVS9c1
✅ Preview: Canceled

[Deployment for 1a37381 canceled]

When we install @nrwl/react we should also install react-test-renderer.

ISSUES CLOSED: nrwl#7578
auto-merge was automatically disabled November 10, 2021 16:04

Head branch was pushed to by a user without write access

@jaysoo jaysoo merged commit 6ac6e98 into nrwl:master Nov 10, 2021
FrozenPandaz pushed a commit that referenced this pull request Nov 11, 2021
When we install @nrwl/react we should also install react-test-renderer.

ISSUES CLOSED: #7578
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with 'react-test-renderer'
2 participants