Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): less loader javascriptEnabled option #8327

Merged
merged 1 commit into from Jun 10, 2022

Conversation

Kyzyl-ool
Copy link
Contributor

@Kyzyl-ool Kyzyl-ool commented Dec 29, 2021

Current Behavior

If run project with antd library and try to compile custom less styles, we have the following error:
Error during bundle: SyntaxError: Inline JavaScript is not enabled. Is it set in your options? in .../node_modules/antd/lib/style/color/bezierEasing.less on line 110, column 1: 109 // https://github.com/ant-design/ant-motion/issues/44 110 .bezierEasingMixin(); 111

Expected Behavior

So we expect not to have this error =)

Related Issue(s)

I didn't found any related issue with javascriptEnabled keyword, so I don't refer to any issue, unfortunately.

Fixes #
To fix the problem, we need to pass javascriptEnabled: true option to less loader inside postcss plugin.

@nx-cloud
Copy link

nx-cloud bot commented Dec 29, 2021

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af10596. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5nU8iDnMNMBJAM1yZSeSa48JdhjB
✅ Preview: https://nx-dev-git-fork-kyzyl-ool-feat-rollup-javascriptena-80d3f7-nrwl.vercel.app

@Kyzyl-ool Kyzyl-ool changed the title Feat/rollup javascript enabled option Feat/rollup javascriptEnabled option Dec 29, 2021
@Kyzyl-ool Kyzyl-ool changed the title Feat/rollup javascriptEnabled option Feat/rollup less loader javascriptEnabled option Dec 29, 2021
@Kyzyl-ool Kyzyl-ool changed the title Feat/rollup less loader javascriptEnabled option feat(web): less loader javascriptEnabled option Dec 29, 2021
@vsavkin vsavkin force-pushed the master branch 2 times, most recently from 3a99403 to 334c230 Compare January 6, 2022 18:35
@jaysoo jaysoo force-pushed the feat/rollup-javascriptEnabled-option branch from 7114862 to e5f1d3c Compare June 10, 2022 13:46
@vercel
Copy link

vercel bot commented Jun 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jun 10, 2022 at 2:42PM (UTC)

@jaysoo jaysoo force-pushed the feat/rollup-javascriptEnabled-option branch from e5f1d3c to 2a71057 Compare June 10, 2022 13:46
@jaysoo jaysoo enabled auto-merge (squash) June 10, 2022 13:46
@jaysoo jaysoo force-pushed the feat/rollup-javascriptEnabled-option branch from 2a71057 to af10596 Compare June 10, 2022 14:39
@jaysoo jaysoo merged commit c421324 into nrwl:master Jun 10, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants