New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): support angular v14.0.0-rc.2 #8883
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/2xPqFsyYaC1PRSY716V88YbRz4UW |
aac46a2
to
84c1f7a
Compare
84c1f7a
to
453bd2b
Compare
453bd2b
to
edf4fc0
Compare
edf4fc0
to
c212da2
Compare
c212da2
to
a4ee567
Compare
a4ee567
to
7e48ec1
Compare
ad2fc4f
to
a387676
Compare
a387676
to
d0eb56f
Compare
d0eb56f
to
985bab9
Compare
985bab9
to
228ccb2
Compare
e46d272
to
d9d049e
Compare
'@nrwl/angular:package', | ||
]; | ||
|
||
export default async function (tree: Tree) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this not use the forEachExecutorOptions function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That function is not a good fit here, we don't need to execute anything per options
or configurations
objects in the target. We also don't need to read anything from the target options or configurations. We only need to identify targets with the right executor so we proceed to scan the project files looking for secondary entry points.
packages/angular/src/migrations/update-14-2-0/update-libraries-secondary-entrypoints.ts
Outdated
Show resolved
Hide resolved
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Nx supports Angular v13
Expected Behavior
Nx supports Angular 14
This includes changes to be compatible with Angular 14:
Related Issue(s)
Fixes #