Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): support angular v14.0.0-rc.2 #8883

Merged
merged 1 commit into from May 30, 2022

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 7, 2022

Current Behavior

Nx supports Angular v13

Expected Behavior

Nx supports Angular 14

This includes changes to be compatible with Angular 14:

  • migrations
  • changes in code generation
  • changes to executors to align with the new APF

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 7, 2022
@nx-cloud
Copy link

nx-cloud bot commented Feb 7, 2022

@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/2xPqFsyYaC1PRSY716V88YbRz4UW
✅ Preview: https://nx-dev-git-fork-leosvelperez-angular-14-nrwl.vercel.app

'@nrwl/angular:package',
];

export default async function (tree: Tree) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this not use the forEachExecutorOptions function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That function is not a good fit here, we don't need to execute anything per options or configurations objects in the target. We also don't need to read anything from the target options or configurations. We only need to identify targets with the right executor so we proceed to scan the project files looking for secondary entry points.

@leosvelperez leosvelperez marked this pull request as ready for review May 30, 2022 16:43
@leosvelperez leosvelperez changed the title [WIP] feat(angular): support angular v14 feat(angular): support angular v14.0.0-rc.2 May 30, 2022
@FrozenPandaz FrozenPandaz merged commit 62afcb7 into nrwl:master May 30, 2022
@leosvelperez leosvelperez deleted the angular-14 branch May 31, 2022 09:27
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants