Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fixes force down compilation for non esm bundles #8907

Merged
merged 1 commit into from Feb 24, 2022

Conversation

ndcunningham
Copy link
Contributor

When you are bundling non esm files we should not force es5 as the target

ISSUES CLOSED: #8639

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

When you use swc as the compiler for a library the types should be generated

ISSUES CLOSED: nrwl#8639
@vercel
Copy link

vercel bot commented Feb 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/3kbsZoojig5BUUrDmeH3moFEFGbn
✅ Preview: Canceled

@jaysoo jaysoo merged commit 68e9435 into nrwl:master Feb 24, 2022
@ndcunningham ndcunningham deleted the fix-rollup-es5 branch February 24, 2022 14:50
meeroslav pushed a commit to meeroslav/nx that referenced this pull request Mar 4, 2022
When you use swc as the compiler for a library the types should be generated

ISSUES CLOSED: nrwl#8639
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/web: Rollup executor forces code output to be ES5
2 participants