Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): use posix path format for generated config.distdir #8990

Merged
merged 1 commit into from Mar 10, 2022
Merged

fix(nextjs): use posix path format for generated config.distdir #8990

merged 1 commit into from Mar 10, 2022

Conversation

lourd
Copy link
Contributor

@lourd lourd commented Feb 16, 2022

ISSUES CLOSED: #8989. See that for context.

Related Issue(s)

Fixes #8989

I've tested this on Windows, confirming that both building and deploying on Windows still works as expected, as well as building on Windows and deploying on Linux, which did not work before.

@vercel
Copy link

vercel bot commented Feb 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/3aH3zTwNtzU4QDdpve4BfAxHWCJd
✅ Preview: Canceled

@lourd
Copy link
Contributor Author

lourd commented Feb 22, 2022

Please let me know if there's anything I can do to help push this along!

@lourd
Copy link
Contributor Author

lourd commented Mar 9, 2022

@kirjai — let me know if there's something else I need to do to get this looked at. Sorry to tag you individually, just saw your name on a lot of past Next.js PRs.

@kirjai kirjai merged commit 5cebe9c into nrwl:master Mar 10, 2022
@kirjai
Copy link
Contributor

kirjai commented Mar 10, 2022

hey @lourd , thanks a lot for both the detailed issue, as well as the PR, really appreciated!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
@lourd lourd deleted the fix-next-dist-dir-windows branch March 22, 2023 05:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/next:build creates Windows-style distDir path when building on Windows
2 participants