New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add more descriptive dependencies build error #9031
fix(core): add more descriptive dependencies build error #9031
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/68NUauKfgGuXfBgFX6YaanzeNLiU [Deployment for 26614df canceled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some failing tests, I think they should be fixed by my suggestion.
Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
21fa587
to
26614df
Compare
Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Right now if you have a library with a dozen dependencies (everything being buildable) and you do not have
targetDependencies
ordependsOn
setup correctly in the project you are trying to build the error makes it seem liketheir is an issue buildable one or more of the dependencies rather than the library itself.
There are really two problems that can occur when building buildable libraries:
root project is configured wrong so that NONE of the deps get build (targetDependencies or dependsOn not setup for it or in the root)
one of the root projects deps is configured wrong so that even though the deps are attempting to be built there is an issue.
The same error is shown in both places.
When does this happen? If you cannot yet configure targetDependencies in the root nx.json because you are refactoring a large legacy repo to have buildable libs then you need to add dependsOn to each project individually, if you forget one you can end up in the situation abov.
Expected Behavior
If the number of dependencies that have not been build yet is equal to the number of dependencies the project has then it can (mostly) be assumed that the project being built is configured wrong rather than one of the others is (which still might be the case)
Related Issue(s)
Fixes #