Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): set the right defaultBase when migrating an angular cli workspace #9050

Merged
merged 1 commit into from Feb 21, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

When migrating an Angular CLI workspace to an Nx workspace, the defaultBase is set to "undefined" if not specified as an option.

Expected Behavior

When migrating an Angular CLI workspace to an Nx workspace, the defaultBase should be set correctly.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 21, 2022
@vercel
Copy link

vercel bot commented Feb 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5tQroAbrqyq7oDZFn97Hs5WnCYLT
✅ Preview: Canceled

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez changed the title fix(angular): fix defaultBase when migrating an angular cli workspace fix(angular): set the right defaultBase when migrating an angular cli workspace Feb 21, 2022
@leosvelperez leosvelperez enabled auto-merge (squash) February 21, 2022 10:49
@leosvelperez leosvelperez merged commit dfcc853 into nrwl:master Feb 21, 2022
@nx-cloud
Copy link

nx-cloud bot commented Feb 21, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 6ee4211. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez deleted the angular/ng-add branch February 21, 2022 11:17
meeroslav pushed a commit to meeroslav/nx that referenced this pull request Mar 4, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants