feat(storybook): add styles and stylePreprocessorOptions to the executors #9057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/2sW9bUxkLd647dwBVzisYZtuadtz |
mandarini
force-pushed
the
feat/include-styles-options-storybook
branch
from
dfaabab
to
57406fd
Compare
mandarini
force-pushed
the
feat/include-styles-options-storybook
branch
from
57406fd
to
17b4715
Compare
|
Use the word |
mandarini
force-pushed
the
feat/include-styles-options-storybook
branch
from
17b4715
to
bebc50d
Compare
This was referenced Feb 21, 2022
Merged
Closed
meeroslav
pushed a commit
to meeroslav/nx
that referenced
this pull request
Mar 4, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Even though a user can pass the
stylesandstylePreprocessorOptionsin the Storybook executors options, and these will be passed onto the Storybook/Angular builders, no documentation exists around it, and the two options are not specifically listed in our schema.Expected Behavior
Add the
stylesandstylePreprocessorOptionsto the Nx Storybook executors. The two options were passed blindly, if provided by the user. However, we now include these two options specifically in our executors' schema. Also added some documentation around it, as requested by the community. The intention is for this to be clearer to users, to provide a better and explicit explanation of how to use in Nx these two Angular builder options.(this Storybook PR for reference)
Related Issue(s)
#8882