Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): update license-webpack-plugin to improve performance #9058

Merged
merged 1 commit into from Mar 10, 2022

Conversation

Phillip9587
Copy link
Contributor

Current Behavior

Nx uses license-webpack-plugin@4.0.0. @angular-devkit/build-angular@13.2.4 and other packages use version 4.0.2. This leads to an extra installed module.

Expected Behavior

Nx should also use license-webpack-plugin@4.0.2 and should add the sematic versioning ^ so that future updates to license-webpack-plugin are used.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Feb 21, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit b9cffaf. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Feb 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/AvzffyoRqTgwTQPMhbUAbQYoMepL
✅ Preview: https://nx-dev-git-fork-phillip9587-license-webpack-plugin-4-0-2-nrwl.vercel.app

@FrozenPandaz FrozenPandaz merged commit dbb4988 into nrwl:master Mar 10, 2022
@Phillip9587 Phillip9587 deleted the license-webpack-plugin-4-0-2 branch September 1, 2022 08:57
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants