feat(node): consolidate js and node plugins

[jaysoo]

This PR consolidates the executors and generators in the @nrwl/js and @nrwl/node plugins.

Why?

We want to move any Node concerns back to the @nrwl/node plugin, same way that we have @nrwl/web handle everything that's specific to the web platform.

The@nrwl/js plugin is trimmed to just handle to generic TypeScript project development--no assumptions on runtime platform. You can still wire up a Node app using only @nrwl/js, just as you could make a web app the using it.

The @nrwl/node plugin provides additional features like static linking (i.e. bundling) that may be desirable when shipping Node apps as microservices.

Note, most of the changes are in the first commit. The other changes are updating docs.

Changes

• Remove @nrwl/js:app generator since it is no longer a use-case for the JS plugin

• Remove @nrwl/js:node executor + migration to use @nrwl/node:node and install @nrwl/node if necessary

• Remove @nrwl/node:package executor since users should use JS plugin to build packages + migration to use @nrwl/js:tsc

• Rename @nrwl/node:build executor to @nrwl/node:webpack + migration

• Rename @nrwl/node:execute executor to @nrwl/node:node + migration

• Update @nrwl/nx-plugin:plugin to use @nrwl/js:library when generating new plugin (instead of @nrwl/node:library)

• Re-enables SWC e2e tests, now that CI is on Node 16

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 1d65804. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 7 targets

• nx affected --target=build --base=7c16cc4199ee014486dd62f0e3176ad3b89ef1fa --head=1d65804d74f2fc75c5b77eb32f8aaeb8cd52429b --parallel=3
• nx affected --target=e2e --base=7c16cc4199ee014486dd62f0e3176ad3b89ef1fa --head=1d65804d74f2fc75c5b77eb32f8aaeb8cd52429b --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=7c16cc4199ee014486dd62f0e3176ad3b89ef1fa --head=1d65804d74f2fc75c5b77eb32f8aaeb8cd52429b --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=7c16cc4199ee014486dd62f0e3176ad3b89ef1fa --head=1d65804d74f2fc75c5b77eb32f8aaeb8cd52429b --parallel=3
• nx affected --target=test --base=7c16cc4199ee014486dd62f0e3176ad3b89ef1fa --head=1d65804d74f2fc75c5b77eb32f8aaeb8cd52429b --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...

---

Sent with 💌 from NxCloud.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4JKqA4f7st6M89yr4RdxEwVLEycN
✅ Preview: https://nx-dev-git-fork-jaysoo-js-webpack-app-nrwl.vercel.app

[Deployment for 1d65804 canceled]

[Alonski]

This is still referenced in the docs 🙃
https://nx.dev/getting-started/nx-and-typescript#create-a-typescript-based-application

Tripped me up why this wasn't working.

[nartc]

Propogated this message internally to see what we could do there. Thank you

[fbartho]

FYI: We didn't get any automatic migrations when we tried to go from 13.8.3 to 13.8.5 -- also, shouldn't this have been a major version update?

[nartc]

@fbartho since we provided the migration, the changes didn't make it to a major version update. I wasn't able to reproduce this. I ran the following commands to try to reproduce:

npx create-nx-workspace@13.8.3 my-workspace --preset=ts --nx-cloud=false
cd my-workspace
npm i -DE @nrwl/express@13.8.3
npx nx g @nrwl/express:app api

At this point, my api serve target has nrwl/node:execute as the executor.

npx nx migrate @nrwl/workspace # migrate to 13.8.5
npm i # run install after update
npx nx migrate --run-migrations # run migrations

Now my api serve target has nrwl/node:node as the executor which proves that the migration was run successfully.

If you still run into issues, please open a new issue with reproduce steps so we can track it better. Thanks.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.