Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): support migrating angular cli workspaces using cypress for e2e tests #9105

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 24, 2022

Current Behavior

It's not possible to migrate an Angular CLI workspace to an Nx workspace when it's using Cypress for the E2E tests.

Expected Behavior

Angular CLI workspaces that are using Cypress can be migrated to an Nx workspace.

Related Issue(s)

Fixes #8383

@leosvelperez leosvelperez self-assigned this Feb 24, 2022
@nx-cloud
Copy link

nx-cloud bot commented Feb 24, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 77d3bff. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Feb 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/8QiA1PhDmvjsJkn4YtbyMkvA3Yhs
✅ Preview: https://nx-dev-git-fork-leosvelperez-angular-ng-add-cypress-2e0819-nrwl.vercel.app

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! 🎉

Worth checking why the e2e-js is failing on an appsDir issue. Is it just an e2e test side effect from modifying workspace?

@leosvelperez leosvelperez marked this pull request as ready for review February 24, 2022 15:25
@leosvelperez leosvelperez marked this pull request as draft February 24, 2022 15:39
@leosvelperez leosvelperez marked this pull request as ready for review February 25, 2022 12:20
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transitioning to Nx fails when current Angular repo has Cypress installed
2 participants