Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): use projectGraph in hasher for calculating dependencies #9118

Merged
merged 2 commits into from Mar 8, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Feb 25, 2022

Custom hasher currently has no access to projectGraph, only taskGraph, which is not useful for flat tasks like the test, lint, etc. By extending TasksSchedule to include projectGraph and pass it to custom hasher implementation we can make sure custom hasher has all the information needed to properly calculate the affected hash.

Current Behavior

Expected Behavior

Related Issue(s)

Related to #8825

@meeroslav meeroslav self-assigned this Feb 25, 2022
@nx-cloud
Copy link

nx-cloud bot commented Feb 25, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 1ca6caf. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4N1ADss1Q23HMPZ2sNuJHd2HivcW
✅ Preview: Canceled

[Deployment for 1ca6caf canceled]

@meeroslav meeroslav changed the title feat(core): give custom hasher factory access to projectGraph fix(linter): use projectGraph in hasher for calculating dependencies Mar 7, 2022
@meeroslav meeroslav merged commit 445cd59 into nrwl:master Mar 8, 2022
@meeroslav meeroslav deleted the fix/linter-hasher-8825-2 branch March 8, 2022 10:25
@fbartho
Copy link

fbartho commented Mar 14, 2022

Our weekly dependabot PRs have started reporting this log message:

warning No cached ProjectGraph is available. The rule will be skipped.
[12](.../runs/5542797452?check_suite_focus=true#step:8:12)
        If you encounter this error as part of running standard `nx` commands then please open an issue on https://github.com/nrwl/nx
[13](.../runs/5542797452?check_suite_focus=true#step:8:13)
        @nrwl/nx/enforce-module-boundaries

Was that maybe introduced by this PR?

@meeroslav
Copy link
Contributor Author

meeroslav commented Mar 15, 2022

No, this seems to be caused by something else.

@fbartho. can you create an issue and if possible provide a repo where we can see this error?

I'm puzzled why would dependabot try to run the linter rule...

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants