New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): use projectGraph in hasher for calculating dependencies #9118
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/4N1ADss1Q23HMPZ2sNuJHd2HivcW [Deployment for 1ca6caf canceled] |
7d38f86
to
ef4eec3
Compare
ef4eec3
to
b189c38
Compare
b189c38
to
b7d6107
Compare
Our weekly dependabot PRs have started reporting this log message:
Was that maybe introduced by this PR? |
No, this seems to be caused by something else. @fbartho. can you create an issue and if possible provide a repo where we can see this error? I'm puzzled why would dependabot try to run the linter rule... |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Custom hasher currently has no access to
projectGraph
, onlytaskGraph
, which is not useful for flat tasks like the test, lint, etc. By extendingTasksSchedule
to include projectGraph and pass it to custom hasher implementation we can make sure custom hasher has all the information needed to properly calculate the affected hash.Current Behavior
Expected Behavior
Related Issue(s)
Related to #8825