feat(core): use package manager workspace globs to find projects #9131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/5GkuqjWaWRNHgnpHHeMusP44VcXF [Deployment for 80bc323 canceled] |
FrozenPandaz
force-pushed
the
pm-workspaces-nodes
branch
from
f29b964
to
b27c1cb
Compare
FrozenPandaz
commented
Feb 28, 2022
| } | ||
|
|
||
| function jsPluginConfig(nxJson: NxJsonConfiguration): NrwlJsPluginConfig { | ||
| return nxJson?.pluginsConfig['@nrwl/js'] ?? {}; |
There was a problem hiding this comment.
Suggested change
| return nxJson?.pluginsConfig['@nrwl/js'] ?? {}; | |
| return nxJson?.pluginsConfig?.['@nrwl/js'] ?? {}; |
FrozenPandaz
force-pushed
the
pm-workspaces-nodes
branch
from
b27c1cb
to
38c3fa5
Compare
FrozenPandaz
force-pushed
the
pm-workspaces-nodes
branch
from
38c3fa5
to
35a0ef7
Compare
AgentEnder
reviewed
Mar 1, 2022
packages/tao/src/shared/workspace.ts
Outdated
| @@ -784,6 +820,8 @@ export function buildWorkspaceConfigurationFromGlobs( | |||
| ): WorkspaceJsonConfiguration { | |||
| const projects: Record<string, ProjectConfiguration> = {}; | |||
|
|
|||
| console.log({ projectFiles }); | |||
There was a problem hiding this comment.
Make sure to remove this, or lock it behind NX_VERBOSE_LOGGING one
FrozenPandaz
force-pushed
the
pm-workspaces-nodes
branch
from
35a0ef7
to
80bc323
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Every single package.json file is used to determine projects for the workspace when
workspace.jsondoes not exist.Expected Behavior
Package manager workspaces glob patterns are used to find projects.
Pnpm is not supported yet.
Related Issue(s)
Fixes #