Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve output color consistency across terminal themes #9133

Merged
merged 1 commit into from Feb 28, 2022

Conversation

JamesHenry
Copy link
Collaborator

I removed all customizations in my VSCode settings and then spent time toggling through many different color themes.

Using the dim() util from chalk (via our output abstraction) produced much more consistently readable output across the different themes vs the gray color util.

Here is a clear example of the comparison using no customizations with the "Tomorrow Night Blue" theme in VSCode.

The Nx Cloud text is still using gray, the rest has had the usage of gray replaced with dim (e.g. in the nx run text, the local cache text etc):

image

@nx-cloud
Copy link

nx-cloud bot commented Feb 26, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 6485451. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Feb 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/AFdVLU1rHqiej2ZKyjtrF4pYnCxs
✅ Preview: Canceled

@vsavkin vsavkin merged commit 471f7be into nrwl:master Feb 28, 2022
@JamesHenry JamesHenry deleted the dynamic-output-color-improvements branch February 28, 2022 20:22
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants