Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ngcli-adapter should work on windows without workspace.json #9163

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Mar 2, 2022

Removes call to angular-devkit normalize when creating FsHost in ngcli-adapter. Appears that it was added to get types to line up, but e2e and tests pass when it's not present. Was causing an issue with globbing for files when workspace.json isn't present.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #9159

@nx-cloud
Copy link

nx-cloud bot commented Mar 2, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit f21dc1b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/E5wyWZbHi1YfZ93x2kMNWjq6vuCM
✅ Preview: Canceled

[Deployment for f21dc1b canceled]

@FrozenPandaz FrozenPandaz force-pushed the fix/ngcli-adapter-fails-on-windows-without-workspace-json branch from a9b79f9 to f21dc1b Compare March 18, 2022 21:48
@FrozenPandaz FrozenPandaz marked this pull request as ready for review March 18, 2022 21:48
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) March 18, 2022 21:56
@FrozenPandaz FrozenPandaz merged commit 6284eb6 into nrwl:master Mar 18, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular build fails on windows when not using workspace.json
2 participants