Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nest): use nrwl/js to generate library #9164

Merged
merged 11 commits into from Mar 3, 2022
Merged

feat(nest): use nrwl/js to generate library #9164

merged 11 commits into from Mar 3, 2022

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Mar 2, 2022

Current Behavior

nrwl/nest:lib calls nrwl/node:lib

Expected Behavior

nrwl/nest:lib now calls nrwl/js:lib

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/FMjhoHq1Uh51RDVRxvkTpZ2AAkeE
✅ Preview: https://nx-dev-git-use-nrwl-js-nrwl.vercel.app

[Deployment for 44da975 canceled]

@nx-cloud
Copy link

nx-cloud bot commented Mar 2, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 44da975. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@jaysoo
Copy link
Member

jaysoo commented Mar 3, 2022

LGTM

@jaysoo jaysoo merged commit 229f71e into master Mar 3, 2022
@jaysoo jaysoo deleted the use-nrwl-js branch March 3, 2022 20:48
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants