Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix invalid style option for nx welcome component when generating an application #9173

Merged
merged 1 commit into from Mar 3, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

When creating an application the Nx Welcome component is created with a wrong style option.

Expected Behavior

The Nx Welcome component should be created correctly.

Related Issue(s)

Fixes #9161
Fixes #9169

@leosvelperez leosvelperez self-assigned this Mar 3, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit bc94bbd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/GNmVvLCe2NFTB94JCvBZMFCLL3Ng
✅ Preview: Canceled

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit b80de97 into nrwl:master Mar 3, 2022
@leosvelperez leosvelperez deleted the angular/fix-style-option branch March 3, 2022 12:47
@simcoder
Copy link

@leosvelperez in what version will this be fixed?

@leosvelperez
Copy link
Member Author

@simcoder it was released on v13.8.5.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Data path ".style" should be equal to one of the allowed values. angular application generator error
3 participants