Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): improve @nrwl/node:node executor to handle build process correctly in watch and no-watch mode #9180

Merged
merged 1 commit into from Mar 4, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 3, 2022

Changes

Watch mode:

  • Only kill previous process if build succeeds (so a server isn't killed unless it can be restarted)
  • File changes only trigger one build (delay of 200ms before re-building)

No watch:

  • Wait for app process to finish before exiting.

Current Behavior

Serve exits before child exits + other weird behavior.

Expected Behavior

Serve should wait for app process to complete.

@vercel
Copy link

vercel bot commented Mar 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CJNGybeY8JgiEDS19A5DSHPR2pRV
✅ Preview: Canceled

[Deployment for bd220dd canceled]

…correctly in watch and no-watch mode

* Build only triggered once on file change
* Kill previous process if it exists
* Wait for build process to finish before exiting
@jaysoo jaysoo force-pushed the node-fix-child-process-handling branch from 9bb4bc3 to bd220dd Compare March 3, 2022 19:23
@jaysoo jaysoo requested a review from nartc March 3, 2022 20:45
@jaysoo jaysoo merged commit 7084d19 into nrwl:master Mar 4, 2022
@mark-b-ab
Copy link

mark-b-ab commented Mar 16, 2022

@jaysoo Hey mate, this issue seems to be on the same topic as your fix. Please take a look, and maybe this will be an easy fix for you

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants