Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): allow use multiple config in custom webpack configuration file #9188

Merged
merged 1 commit into from Mar 10, 2022

Conversation

sidmonta
Copy link
Contributor

@sidmonta sidmonta commented Mar 4, 2022

When use a custom configuration file for webpack build target, allow running webpack with
multiple configuration options.
ISSUES CLOSED: #9186

Current Behavior

Assigning a custom webpack configuration file does not support the ability to use multiple configurations, as webpack allows.

Expected Behavior

Being able to define multiple configurations in my custom webpack.config.ts file to feed to webpack

Related Issue(s)

#9186

Fixes #

…guration file

When use a custom configuration file for webpack build target allow to run webpack with
multiple
configuration options.
ISSUES CLOSED: nrwl#9186
@nx-cloud
Copy link

nx-cloud bot commented Mar 4, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 750954c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/9Hngw6QRzASYJ3txXT7j7AtbBLe7
✅ Preview: Canceled

@AgentEnder AgentEnder requested a review from kirjai March 4, 2022 14:07
@kirjai kirjai merged commit 37278fd into nrwl:master Mar 10, 2022
@kirjai
Copy link
Contributor

kirjai commented Mar 10, 2022

hi @sidmonta , thanks for the contribution, looks good to me! really appreciated

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/web:webpack Cannot use multiple configuration on custom config file option
2 participants