Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nxdev): cover hero background on wide screens #9190

Merged

Conversation

meeroslav
Copy link
Contributor

Current Behavior

On widescreen, the background image on the hero is stuck on the right thanks to bg-right and bg-contain
Screenshot 2022-03-04 at 12 38 52

Expected Behavior

The image should cover the hero block without leaving empty parts on super widescreens.
Screenshot 2022-03-04 at 12 39 24

Related Issue(s)

Fixes #

@meeroslav meeroslav requested a review from bcabanes March 4, 2022 11:39
@meeroslav meeroslav self-assigned this Mar 4, 2022
@vercel
Copy link

vercel bot commented Mar 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/AtNaBtGTkEttQuNx7gQNb7cMdT3Q
✅ Preview: https://nx-dev-git-fork-meeroslav-web-fix-hero-background-o-018e13-nrwl.vercel.app

@bcabanes bcabanes merged commit d599dd5 into nrwl:master Mar 4, 2022
@meeroslav meeroslav deleted the web/fix-hero-background-on-wide-screen branch November 8, 2022 15:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants