fix(misc): support workspaces using a root tsconfig.json instead of tsconfig.base.json #9195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/63Hzqex68s9NBcBNLFGDHGMhTsdy [Deployment for 1454a02 canceled] |
leosvelperez
force-pushed
the
misc/root-tsconfig
branch
from
f6e2fec
to
ae84691
Compare
leosvelperez
force-pushed
the
misc/root-tsconfig
branch
from
ae84691
to
67ccbcc
Compare
leosvelperez
force-pushed
the
misc/root-tsconfig
branch
from
67ccbcc
to
7996a79
Compare
FrozenPandaz
requested changes
Mar 7, 2022
packages/angular/src/generators/application/lib/create-files.ts
Outdated
Show resolved
Hide resolved
leosvelperez
force-pushed
the
misc/root-tsconfig
branch
from
1da8cab
to
1454a02
Compare
FrozenPandaz
approved these changes
Mar 9, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There are several places within Nx where it doesn't fall back to locate a root
tsconfig.jsonif the expectedtsconfig.base.jsondoesn't exist.Most of the time this should be fine since Nx workspaces by default use
tsconfig.base.json, but there are still some scenarios where atsconfig.jsonmight still be used (e.g. devs decide to use it, or Angular CLI workspaces migrated using a package likemake-angular-cli-fasteror Angular CLI workspaces migrated using the--preserve-angular-cli-layoutflag).Expected Behavior
The functionality within Nx should look for a root
tsconfig.jsonif thetsconfig.base.jsonfile doesn't exist. By default,tsconfig.base.jsonshould still be used for everything and it's still the recommended file to use, but a fallback should be in place.Related Issue(s)
Fixes #