Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix daemon server path on client #9235

Merged
merged 1 commit into from Mar 8, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

A change made in #9223 to ensure the CWD is always the same when processing the project graph with or without a daemon, caused the server file path to be wrong. This causes the daemon to fail to compute the project graph with the following error:

Error: Cannot find module '/Users/leosvel/code/issues/server/start.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)
    at Function.Module._load (internal/modules/cjs/loader.js:730:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Expected Behavior

The daemon should compute the project graph correctly.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Mar 8, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 6704ded. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez self-assigned this Mar 8, 2022
@vercel
Copy link

vercel bot commented Mar 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/6CC65JDZS7c1VN6vExFdcMcLx1vi
✅ Preview: Canceled

@leosvelperez leosvelperez changed the title fix(core): fix daemon server path fix(core): fix daemon server path on client Mar 8, 2022
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I didn't notice the error when testing locally, not sure why it didn't occur 🤷

@leosvelperez leosvelperez merged commit 5ada5ad into nrwl:master Mar 8, 2022
@leosvelperez leosvelperez deleted the core/fix-daemon-server-path branch March 8, 2022 16:34
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants