Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): prevent storybook from hoisting webpack 4 for angular #9243

Merged
merged 1 commit into from Mar 9, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 9, 2022

Current Behavior

Adding storybook configuration with yarn via our generators causes webpack 4 dep from @storybook/angular to be hoisted.

Expected Behavior

We should stick to webpack 5 for Angular apps. Storybook shouldn't be overwriting the root webpack dependency in the node_modules folder

Related Issue(s)

Fixes #9154

@Coly010 Coly010 requested a review from mandarini March 9, 2022 10:14
@Coly010 Coly010 self-assigned this Mar 9, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 9, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit c4ca525. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/71uN2BGd4KYPYxuuDFEQy1FpChP3
✅ Preview: Canceled

[Deployment for c4ca525 canceled]

@mandarini mandarini enabled auto-merge (squash) March 9, 2022 10:46
@mandarini mandarini merged commit aac9b68 into nrwl:master Mar 9, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring storybook to an angular library breaks Module Federation
2 participants