fix(angular): handle newProjectRoot correctly when generating apps and libs

[leosvelperez]

Current Behavior

In workspaces where the newProjectRoot config might be specified in the angular.json (v1 format), there are issues creating applications and libraries. The @schematics/angular:application or @schematics/angular:library generator use that property if present to create the projects and then, the @nrwl/* generators move the projects to the final destination.

Most workspaces won't have this issue since that option doesn't get generated in new Nx workspaces and it gets deleted when migrating an Angular CLI workspace to an Nx workspace. However, if an Angular CLI workspace is migrated preserving the Angular CLI layout, the option is not meant to be removed and therefore it still needs to be handled correctly. In that scenario, the Angular CLI schematics need to work as usual, and for that, the option needs to be present.

A recent PR #8865 made a change to always remove the option when updating the configuration which is not something desired when a workspace preserves the Angular CLI layout.

Expected Behavior

In workspaces where the newProjectRoot option is set in the configuration, the @nrwl/angular:app and @nrwl/angular:lib should handle it and work correctly. The newProjectRoot option shouldn't be deleted when updating the configuration if it's not meant to be deleted.

Related Issue(s)

Fixes #

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 34740f0. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 7 targets

• nx affected --target=build --base=1440f8362c07dc8c8414b12423b7776f824271b9 --head=34740f0c2b9efacf5a2427f32816eef1844de997 --parallel=3
• nx affected --target=e2e --base=1440f8362c07dc8c8414b12423b7776f824271b9 --head=34740f0c2b9efacf5a2427f32816eef1844de997 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=1440f8362c07dc8c8414b12423b7776f824271b9 --head=34740f0c2b9efacf5a2427f32816eef1844de997 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=1440f8362c07dc8c8414b12423b7776f824271b9 --head=34740f0c2b9efacf5a2427f32816eef1844de997 --parallel=3
• nx affected --target=test --base=1440f8362c07dc8c8414b12423b7776f824271b9 --head=34740f0c2b9efacf5a2427f32816eef1844de997 --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...

---

Sent with 💌 from NxCloud.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/BNB61DPJHCCyoZk5PAmDyRKQuNT1
✅ Preview: Canceled

[Coly010]

LGTM! 🎉

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.