Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): show warning about version 5 support drop #9257

Merged
merged 1 commit into from Mar 9, 2022

Conversation

mandarini
Copy link
Member

Current Behavior

With Nx 14, we will drop support for Storybook version 5. Users are unaware at the moment

Expected Behavior

A warning is shown when a user tries to run/build/generate Storybook, prompting the user to upgrade.

@nx-cloud
Copy link

nx-cloud bot commented Mar 9, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 11aeef0. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5JQjbZUrGR6VPpoK7bma751NMKvT
✅ Preview: Canceled

[Deployment for 11aeef0 canceled]

@mandarini mandarini force-pushed the feat/show-storybook-warning branch from 52ef900 to 11aeef0 Compare March 9, 2022 19:25
@mandarini mandarini enabled auto-merge (squash) March 9, 2022 19:38
@mandarini mandarini merged commit 261b35d into nrwl:master Mar 9, 2022
@mandarini mandarini deleted the feat/show-storybook-warning branch March 18, 2022 14:47
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants