fix(node): npm modules are not resolved correctly #9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/9rpo3kgwfWj4C6AvSSEerXemda1A [Deployment for 5cc29a2 canceled] |
hellivan
changed the title
The current implementation of the node executor resolves all npm modules that are referenced by the application from the root node_modules folder. This behavior leads to runtime errors if any of the project dependencies requires a different version of a package than the project itself. For example, if we have a project that depends on `express` in version `4.17.3` (which on the other hand depends on `path-to-regexp` version `0.1.7`) as well as on `path-to-regexp` in version `6.2.0`. In such case `express` will throw a runtime error since it would load `path-to-regexp` version `6.2.0` which is not API compatible. For this reason, this commit changes the behavior of the node-executor so that it completely ignores npm dependencies when calculating resolve mappings.
hellivan
force-pushed
the
fix/npm_modules_resolution
branch
from
8ea3f27
to
5cc29a2
Compare
FrozenPandaz
approved these changes
Mar 18, 2022
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 21, 2022
The current implementation of the node executor resolves all npm modules that are referenced by the application from the root node_modules folder. This behavior leads to runtime errors if any of the project dependencies requires a different version of a package than the project itself. For example, if we have a project that depends on `express` in version `4.17.3` (which on the other hand depends on `path-to-regexp` version `0.1.7`) as well as on `path-to-regexp` in version `6.2.0`. In such case `express` will throw a runtime error since it would load `path-to-regexp` version `6.2.0` which is not API compatible. For this reason, this commit changes the behavior of the node-executor so that it completely ignores npm dependencies when calculating resolve mappings.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The current implementation of the node executor resolves all npm modules that are referenced by the application from the root node_modules folder. This behavior leads to runtime errors if any of the project dependencies requires a different version off package than the project itself.
For example, if we have a project that depends on
expressin version4.17.3(which on the other hand depends onpath-to-regexpversion0.1.7) as well as onpath-to-regexpin version6.2.0. In such caseexpresswill throw a runtime error since it would loadpath-to-regexpversion6.2.0which is not API compatible.Expected Behavior
Node executor should not add resolve mappings for npm modules at all.