fix(linter): use import to check for secondary entrypoint in angular

[meeroslav]

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #8059

Related to nrwl/nx-examples#179

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 4bad20f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 7 targets

• nx affected --target=build --base=a32d46c5a36246b2349d72f7b50f7f0e532744bb --head=4bad20f9304f29249492d721a349f61992dd7dd7 --parallel=3
• nx affected --target=e2e --base=a32d46c5a36246b2349d72f7b50f7f0e532744bb --head=4bad20f9304f29249492d721a349f61992dd7dd7 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=a32d46c5a36246b2349d72f7b50f7f0e532744bb --head=4bad20f9304f29249492d721a349f61992dd7dd7 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=a32d46c5a36246b2349d72f7b50f7f0e532744bb --head=4bad20f9304f29249492d721a349f61992dd7dd7 --parallel=3
• nx affected --target=test --base=a32d46c5a36246b2349d72f7b50f7f0e532744bb --head=4bad20f9304f29249492d721a349f61992dd7dd7 --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...

---

Sent with 💌 from NxCloud.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/D3sqkUUt93CdYEtPcb54ViqNeMdq
✅ Preview: Canceled

[Deployment for 4bad20f canceled]

[Coly010]

LGTM 🎉

[codephobia]

@meeroslav Am I correct in my assumption that this fix will not work for wildcard paths used for secondary entry points?

[meeroslav]

I would expect it to work @codephobia. Do you have a repro that shows otherwise?

[codephobia]

@meeroslav The problem I am seeing is if I try to use a wildcard path for any nested folder within the lib I get the relative path error for the secondary entry point. I've got about 50 entry points for components, some of which are using other components as children. I would prefer to avoid putting them in the root folder of the library since there is other things in the library currently (storybook, schematics, docs, etc) and it makes it look like a mess.

Example path:
"@lib-name/*": ["libs/lib-name/some-folder/*/src/index.ts"],

Error:
Projects should use relative imports to import from other files within the same project. Use "./path/to/file" instead of import from "@lib-name/secondary-entry-point".

I can try to make some time today to repro the issue if that helps.

[codephobia]

@meeroslav I made a repro of the issue and it seems to work as expected. Must be something in the current setup I have, or the fact that we are still on Nx 13.10.5. At least I know that it should work now, just need to figure out what is needed to get there. Repro: https://stackblitz.com/edit/nx-sgjrmx

[codephobia]

@meeroslav Upon further investigation, I have a feeling that the folder (libs/my-library/some-folder) is not being linted as expected. It seems that if you include the folder in the lintFilePatterns you then start to see the errors I am experiencing in my project. I have updated the repro accordingly. If you go to https://stackblitz.com/edit/nx-sgjrmx and run the command nx run my-library:lint you will see the error I am experiencing.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.