Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): update package.json only with shallow dependencies #9297

Merged
merged 1 commit into from Mar 11, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 11, 2022

This PR fixes a bug where building a parent lib includes npm dependencies from its workspace libs it depends on in the generated package.json file.

Current Behavior

All npm dependencies from workspace dependencies are recursively picked up.

Expected Behavior

Only parent lib's npm dependencies should be present.

Fixes #8640

@nx-cloud
Copy link

nx-cloud bot commented Mar 11, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit a777fe1. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5r9p8hb1xfuJj3utgPmXM4qSvVWZ
✅ Preview: Canceled

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/web|@nrwl/workspace: Package gets all dependencies of its children
1 participant