Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): fixing the static-dir issue #9313

Merged
merged 1 commit into from Mar 14, 2022

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Mar 14, 2022

Current Behavior

  • The addition of "default": [] to the staticDir option in the Storybook executor schema, breaks it when a user provides staticDirs in main.js. This should not happen.

Expected Behavior

Related Issue(s)

Fixes #9306

@nx-cloud
Copy link

nx-cloud bot commented Mar 14, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit f8111de. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/EgJPoJHcVAv51TiLKTnA4UEdsuTA
✅ Preview: https://nx-dev-git-fork-mandarini-fix-storybook-static-dir-nrwl.vercel.app

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@mandarini mandarini merged commit dbbd7ef into nrwl:master Mar 14, 2022
@mandarini mandarini deleted the fix/storybook-static-dir branch March 18, 2022 14:47
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants