fix(angular): update library package.json only with direct dependencies #9315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/pj7nGwM7eVKbiJYMJfUtM8gBAT3y [Deployment for 7eb6275 canceled] |
leosvelperez
force-pushed
the
angular/package-json-deps
branch
from
2546463
to
f8bf6d6
Compare
leosvelperez
force-pushed
the
angular/package-json-deps
branch
from
f8bf6d6
to
e7d1e9f
Compare
leosvelperez
force-pushed
the
angular/package-json-deps
branch
from
e7d1e9f
to
7eb6275
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix similar to #9297. The difference is that for Angular all deps are still needed to be collected to properly remap the TS path mappings, but only the direct deps are needed for updating the
package.json.Current Behavior
When building a library, the
package.jsonends up with all the dependencies including the ones that are not direct dependencies. Transitive dependencies would be installed as part of the library's direct dependencies, there's no need to specify them as dependencies of the library.Expected Behavior
The
package.jsonof a built library should only contain direct dependencies.Related Issue(s)
Fixes #