fix(web): fix handling of buildLibsFromSource: false in dev-server executor #9326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecutor * modify buildOptions.tsConfig before creating Webpack config * do not join buildOptions.tsConfig to root path as it is already an absolute path
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/HpoccT91KvU1EpQPruRf6XkHUawG |
FrozenPandaz
changed the title
buildLibsFromSource: false in dev-server executor
FrozenPandaz
approved these changes
Mar 18, 2022
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 21, 2022
…ecutor (#9326) * modify buildOptions.tsConfig before creating Webpack config * do not join buildOptions.tsConfig to root path as it is already an absolute path
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(web): fix handling of
buildLibsFromSource: falseindev-serverexecutorbuildOptions.tsConfigbefore creating Webpack configbuildOptions.tsConfigto root path as it is already an absolute pathCurrent Behavior
The
dev-serverexecutor of@nrwl/webdoesn't respect the optionbuildLibsFromSource: false. There are two causes of this behavior:buildOptions.tsConfigneeded forbuildLibsFromSource: falseis applied after creating the Webpack config while it should be done before creating the Webpack config.buildOptions.tsConfigis joined tocontext.rootalthough it is already an absolute path.Note that the
webpackexecutor, which has the same option, already works correctly.Expected Behavior
The
dev-serverexecutor of@nrwl/webrespects the optionbuildLibsFromSource: false. If this option is set, existing build artifacts of libraries are used instead of rebuilding them from source.