Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add buildLibsFromSource option to @nrwl/angular:webpack-browser executor #9334

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

There's no way to opt-out of incremental builds when using the @nrwl/angular:webpack-browser.

Expected Behavior

The @nrwl/angular:webpack-browser shouldn't be tied nor default to incremental builds, using it should be explicit. It has other features that are more likely to be used in isolation like supporting custom webpack configuration that can be used in isolation.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 15, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 15, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit da08332. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/2zrmGRDmiVnNPcA9dxXuYiwq4XSm
✅ Preview: https://nx-dev-git-fork-leosvelperez-angular-build-libs-fro-ea763b-nrwl.vercel.app

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit a82edb1 into nrwl:master Mar 15, 2022
@leosvelperez leosvelperez deleted the angular/build-libs-from-source branch March 15, 2022 15:33
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants