Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix cli to properly handle the migrate command after the packages consolidation #9352

Merged
merged 1 commit into from Mar 16, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

When running the migrate command from a version older than v13.9.0 to latest, the command doesn't run properly and keeps opening new processes to run itself.

This happens because in the old versions tao migrate will be run, but the migrate command installs the latest version of @nrwl/tao which now defers the execution to the nx package and this one is only handling _migrate as the command for running the migration but not migrate. Because of that, it doesn't identify it as the migration command and it continues the execution which ends up running the migrate command again.

Expected Behavior

Migrations should run successfully.

Related Issue(s)

Fixes #9345

@leosvelperez leosvelperez self-assigned this Mar 16, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 16, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 1bdcd7f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/ZMmMpNrNXP2QbNXTmwrZbWvbb9DP
✅ Preview: Canceled

@leosvelperez leosvelperez changed the title fix(core): fix migrate command to properly handle the packages consolidation fix(core): fix cli to properly handle the migrate command after the packages consolidation Mar 16, 2022
@FrozenPandaz FrozenPandaz merged commit 39554b9 into nrwl:master Mar 16, 2022
@leosvelperez leosvelperez deleted the fix-migrations branch March 21, 2022 12:20
@matt-ganz
Copy link

matt-ganz commented Jul 7, 2022

I just migrated from Nx 13.1.3 to 14.0.0 and noticed that my nx migrations were failing silently. Then i saw that the migration didn't update nrwl/tao so my old version was still there (13.1.3). i manually updated tao to 14.0 and ran npm install and nx migrations and then it started working. but when i look now at my package.json i see that tao is now gone. i'm guessing Nx 14 moved away from Tao. but why am i still getting the node processes error (i mean my builds are still hanging).

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx migrate is fork bombing my laptop
3 participants