New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE - feat(angular): add generator to migrate old mfe config #9366
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/GofxKSRFyGiUc8NLgZTa1t9W8Vcp |
packages/angular/src/generators/move-to-with-mf/move-to-with-mf.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/move-to-with-mf/move-to-with-mf.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/move-to-with-mf/move-to-with-mf.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/move-to-with-mf/move-to-with-mf.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/move-to-with-mf/lib/get-webpack-config-path.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/move-to-with-mf/lib/write-new-webpack-config.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/move-to-with-mf/lib/write-new-webpack-config.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/move-to-with-mf/lib/write-new-webpack-config.ts
Outdated
Show resolved
Hide resolved
5d8fa9b
to
f6ca622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are just a couple of small typos left.
Apart from that, the change to use the word convert
was done only in a few places, but almost all (if not all) files/dirs, the generator function name and other places are still using move
. Could you update that so we keep a consistent naming?
packages/angular/src/generators/move-to-with-mf/move-to-with-mf.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/move-to-with-mf/move-to-with-mf.ts
Outdated
Show resolved
Hide resolved
f6ca622
to
7866388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
No automated method to migrate from current MFE configs to new MFE configs
Expected Behavior
Should have an automated method for migrating to new MFE configs considering:
Because every npm and workspace library dependent gets shared automatically, we can safely migrate those, whether defined or not in current configs.
We should always use tuple syntax for Host app's remote definitions, as they could have been changed and may not be possible to be inferred correctly.
If code produces unwanted results, user can revert the changes safely.
Things out of scope right now:
withModuleFederation
withModuleFederation
approach is ready and can be used safely.