Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): set tsconfig path correctly #9375 #9386

Merged
merged 1 commit into from Mar 18, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 18, 2022

Current Behavior

Fixing the incremental builds opt out accidentally lead to erroneous behaviour in MFEs.

Expected Behavior

Only set the env var for TS Config Path when incremental builds change the tsconfig path, otherwise fall back to the path defined in the webpack config.

Related Issue(s)

Fixes #9375

@Coly010 Coly010 self-assigned this Mar 18, 2022
@vercel
Copy link

vercel bot commented Mar 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/C6DfHiQ4pysiVsMqMJQxh7P377su
✅ Preview: Canceled

[Deployment for 5659eef canceled]

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit 08c6b02 into nrwl:master Mar 18, 2022
@Coly010 Coly010 deleted the fix/angular-mfe-tsconfig branch March 18, 2022 11:43
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error building when using mfe
2 participants