Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): when building set node_env #9390

Merged
merged 1 commit into from Mar 18, 2022

Conversation

mandarini
Copy link
Member

ISSUES CLOSED: #8403

Current Behavior

This issue mainly: #8403

Expected Behavior

To work without errors when opening index.html in the browser

Related Issue(s)

8403

Fixes #8403

@nx-cloud
Copy link

nx-cloud bot commented Mar 18, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 881b781. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/94mYNsHPJ5i6cAio9frVU2mZ7UYf
✅ Preview: Canceled

@mandarini mandarini requested a review from Coly010 March 18, 2022 13:26
@mandarini mandarini self-assigned this Mar 18, 2022
@mandarini mandarini enabled auto-merge (squash) March 18, 2022 13:34
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@mandarini mandarini merged commit 483115b into nrwl:master Mar 18, 2022
@mandarini mandarini deleted the fix/storybook-build-node-env branch March 18, 2022 14:49
FrozenPandaz pushed a commit that referenced this pull request Mar 21, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[build-storybook]: react publishable library TypeError: (0 , jsx_dev_runtime.jsxDEV) is not a function
2 participants