Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add support for MFEs #9413

Merged
merged 2 commits into from Apr 4, 2022
Merged

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Mar 19, 2022

Things to Do

  • Add Unit test
  • Configure exposes so that it maps relative paths
  • Clean up template files / Add template files for shell apps when remotes are passed in. (probably nice to have)
  • Configure webpack-config.prod.ts (Dynamic Host for apps)
  • Add mfe-remote command (Should configure host)

Current Behavior

Expected Behavior

Be able to run something similar to nx g @nrwl/react:mfe-host my-shell --remotes about,dashboard which will generate a shell application that has references to the remotes given.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Mar 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e0b5557. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/FzoF67DN2tNBWrqURGD7ZuhBbR4Z
✅ Preview: https://nx-dev-git-fork-ndcunningham-feat-mfe-host-nrwl.vercel.app

@jaysoo jaysoo changed the title DRAFT: feat(react): add Generator for MFE Host feat(react): add support for MFEs Apr 4, 2022
Nicholas Cunningham and others added 2 commits April 4, 2022 14:40
Host generator will be able use the mfe-remote generator when remotes are passed into the CLI for the mfe-host command
@Elvis116
Copy link

Is there a plan to support loadRemoteModule?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants