Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): change mfe schema port type to number #9420

Merged
merged 1 commit into from Mar 21, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Mar 21, 2022

Port should be number. Having it as string breaks one of the nightlies with:

Property 'port' does not match the schema. '4205' should be a 'string'.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: angular Issues related to Angular support in Nx label Mar 21, 2022
@meeroslav meeroslav requested a review from Coly010 March 21, 2022 08:25
@meeroslav meeroslav self-assigned this Mar 21, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 21, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 8f1ae41. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CtFevRRAURNsJCrieTMhXADqpF8X
✅ Preview: https://nx-dev-git-fork-meeroslav-chore-fix-mfe-port-type-nrwl.vercel.app

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

@meeroslav meeroslav merged commit 99d871a into nrwl:master Mar 21, 2022
@meeroslav meeroslav deleted the chore/fix-mfe-port-type branch March 21, 2022 11:04
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: angular Issues related to Angular support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants