feat(angular): automatically set next remote port #9422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/An3iQnv1p4M5DpBiV6uPGVXRgkHN [Deployment for a309639 canceled] |
leosvelperez
approved these changes
Mar 21, 2022
| ports.add(port); | ||
| } | ||
|
|
||
| const nextAvailablePort = [...ports].sort((a, b) => b - a)[0] + 1; |
There was a problem hiding this comment.
nit: we could improve readability a bit by doing:
Suggested change
| const nextAvailablePort = [...ports].sort((a, b) => b - a)[0] + 1; | |
| const nextAvailablePort = Math.max(...ports) + 1; |
Coly010
force-pushed
the
angular/auto-find-new-port
branch
from
8aa79a1
to
a309639
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We expect people to pass a port for their remote apps. However, we default to
4200if they do not. This can cause conflicts when a host app has multiple remotes on the same port.Expected Behavior
Instead of defaulting to
4200, scan the ports used in the workspace and pick a port that is 1 greater than the highest value.We should not run into issues with reserved ports as the current range of ports is open for use.
In development, the user shouldn't need to care where their remotes are being served if they are being accessed via host.
Also, the
servecommand on a remote app will specify the URL of the served app.