Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): use importPath as package.json name when passed #9430

Merged
merged 1 commit into from Mar 21, 2022

Conversation

gioragutt
Copy link
Contributor

Current Behavior

When creating a new plugin using importPath, the generated plugin's package.json is not using it.

F.E:

$ npx create-nx-workspace@latest --packageManager=yarn --preset=empty my-workspace
$ cd my-workspace
$ yarn add -D @nrwl/nx-plugin
$ nx g @nrwl/nx-plugin:plugin --name=my-plugin --importPath=@my-company/my-plugin
$ jq '.name' libs/my-plugin/package.json
"@my-workspace/my-plugin"

Expected Behavior

$ npx create-nx-workspace@latest --packageManager=yarn --preset=empty my-workspace
$ cd my-workspace
$ yarn add -D @nrwl/nx-plugin
$ nx g @nrwl/nx-plugin:plugin --name=my-plugin --importPath=@my-company/my-plugin
$ jq '.name' libs/my-plugin/package.json
"@my-company/my-plugin"

Related Issue(s)

Fixes #9415

@vercel
Copy link

vercel bot commented Mar 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5o7vVrRzDhWxKM5uJZWgvyDkTYMU
✅ Preview: Canceled

[Deployment for 2e11486 canceled]

@AgentEnder
Copy link
Member

LGTM 🎉

@AgentEnder AgentEnder enabled auto-merge (squash) March 21, 2022 14:28
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generating a plugin with importPath does not set package.json name to it
2 participants