Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): ensure file server works on windows #9449

Merged
merged 1 commit into from Mar 22, 2022

Conversation

meeroslav
Copy link
Contributor

In #9330 we replaced exec with execFile which requires explicit shell property set on Windows otherwise commands fail with ENOENT.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #9444 and nightly build on Windows

@meeroslav meeroslav added type: bug scope: core core nx functionality labels Mar 22, 2022
@meeroslav meeroslav self-assigned this Mar 22, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 22, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit edfe894. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/EPBZW4z3twwmpmrzWci2CqTkdZwz
✅ Preview: Canceled

[Deployment for edfe894 canceled]

@meeroslav meeroslav changed the title fix(core): ensure execFile process runs with shell fix(web): ensure execFile process runs with shell Mar 22, 2022
@meeroslav meeroslav changed the title fix(web): ensure execFile process runs with shell fix(web): ensure file server works on windows Mar 22, 2022
@meeroslav meeroslav merged commit 41914d2 into nrwl:master Mar 22, 2022
@meeroslav meeroslav deleted the fix/ensure-spawn-shell branch March 22, 2022 21:39
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web file server halts on Windows
2 participants