Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): browser builder should call correct function #9457

Merged
merged 1 commit into from Mar 22, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 22, 2022

Current Behavior

Using custom webpack config for building will fail

Expected Behavior

Using custom webpack config for building should not fail

Notes

Not sure why original e2es passed this. Most recent run of e2es for #9454 failed on it.

@Coly010 Coly010 self-assigned this Mar 22, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 22, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 2a4c709. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/GTVGqKHCMFbNpxkS61oNUpEDMr3h
✅ Preview: Canceled

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 enabled auto-merge (squash) March 22, 2022 14:03
@Coly010 Coly010 merged commit 933cd59 into nrwl:master Mar 22, 2022
@Coly010 Coly010 deleted the angular/fix-browser-builder branch March 22, 2022 14:59
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants