fix(react): fix conflicting NODE_ENV values between an application an…

[ndcunningham]

Fix conflicting NODE_ENV values between an application and webpack Plugins (DefinePlugin)

ISSUES CLOSED: #7924

Current Behavior

Currently, serving a fresh Nx React application shows the following:

WARNING in DefinePlugin
Conflicting values for 'process.env.NODE_ENV'

Expected Behavior

On freshly served applications there should be no such warning as stated above.

Related Issue(s)

Fixes #

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 99182fe. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 7 targets

• nx affected --target=build --base=0331b381bc7f90b2c967af241429ba1c903dd098 --head=99182fe67bd208d0ab73aead16c7835b4a7a08d0 --parallel=3
• nx affected --target=e2e --base=0331b381bc7f90b2c967af241429ba1c903dd098 --head=99182fe67bd208d0ab73aead16c7835b4a7a08d0 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=0331b381bc7f90b2c967af241429ba1c903dd098 --head=99182fe67bd208d0ab73aead16c7835b4a7a08d0 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=0331b381bc7f90b2c967af241429ba1c903dd098 --head=99182fe67bd208d0ab73aead16c7835b4a7a08d0 --parallel=3
• nx affected --target=test --base=0331b381bc7f90b2c967af241429ba1c903dd098 --head=99182fe67bd208d0ab73aead16c7835b4a7a08d0 --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...

---

Sent with 💌 from NxCloud.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/8qFwYSAHzw1zuA7tm8gz4jYHwzKR
✅ Preview: Canceled

[jaysoo]

LGTM

[nemonemi]

This should be possible to be shortened and simplified:

typeof options.optimization === 'boolean'
      ? options.optimization
      : options.optimization?.scripts || false

[nemonemi]

Has this been released yet?

[RJSonnenberg]

Has this been released yet?

Not yet, @nemonemi. 13.9.4 was released before this fix was merged. 13.9.5 should include this fix.

[tijmenvangurp]

13.9.5 should include this fix.

Any idea when this will be released? looking for a fix to this issue!

[nemonemi]

This issue has not been resolved with 13.9.5.

[RJSonnenberg]

I can confirm, the issue still remains on both existing apps and newly-generated apps. Verified that both global and local nx was on 13.9.5. Serving app on Windows still results in the following warning:

WARNING in DefinePlugin
Conflicting values for 'process.env.NODE_ENV'

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.