Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): build project's that have buildable dependencies without package.json's #9466

Merged
merged 3 commits into from Apr 8, 2022

Conversation

pemsbr
Copy link
Contributor

@pemsbr pemsbr commented Mar 22, 2022

Current Behavior

Not able to build project's that have buildable dependencies without package.json's

Related Issue(s)

Fixes #8707

@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/Eugzqk4Ackdjx16gMikRJ4kM7VCh
✅ Preview: Canceled

[Deployment for 9e9aaed canceled]

@pemsbr pemsbr changed the title fix(core): check if package.json exists (#8707) fix(core): build project's that have buildable dependencies without package.json's (#8707) Mar 22, 2022
@pemsbr pemsbr changed the title fix(core): build project's that have buildable dependencies without package.json's (#8707) fix(core): build project's that have buildable dependencies without package.json's (#8707) Mar 22, 2022
@pemsbr pemsbr changed the title fix(core): build project's that have buildable dependencies without package.json's (#8707) fix(core): build project's that have buildable dependencies without package.json's Mar 23, 2022
@nartc
Copy link
Contributor

nartc commented Apr 8, 2022

@pemsbr thank you for the PR. I just rebased the branch as it's a bit old. As soon as CI is green, I'll merge it. Thanks again

@jackpordi
Copy link

#9466 seems to have been merged but it's still not quite working for me - has this been released? I'm on NX version 14.1.4

@0xZoomEye
Copy link

#9466 seems to have been merged but it's still not quite working for me - has this been released? I'm on NX version 14.1.4
I'm on 14.1.14 too. I still got this problem.

nx run account:build:production

nx run account:build:production

Compiling TypeScript files for project "account"...
Done compiling TypeScript files for project "account".
node:fs:585
handleErrorFromBinding(ctx);
^

Error: ENOENT: no such file or directory, open 'apps/account/package.json'

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to build project's that have buildable dependencies without package.json's
6 participants