Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): improve inconsistencies with assets in tsc and swc compared to node:package #9470

Merged
merged 1 commit into from Mar 23, 2022

Conversation

AgentEnder
Copy link
Member

Current Behavior

Files referenced by a string that are located in workspace root are copied to incorrect location during the build, and not copied at all if --watch is on

Expected Behavior

Files referenced by a string that are located in workspace root are copied to package build location during build, regardless of --watch

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Mar 22, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit b584b4b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder requested a review from jaysoo March 22, 2022 21:32
@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CyhHfV1wUBDnG7fxQCyMDmbGDAiY
✅ Preview: Canceled

Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaysoo jaysoo merged commit 2f85238 into nrwl:master Mar 23, 2022
FrozenPandaz pushed a commit that referenced this pull request Mar 25, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants