New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): add root karma config if one isn't present for karma-project generator #9485
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/DCmSr2us3LG4AotCnDzvnArjXD5F |
e0ecb96
to
f3c8dcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
…arma-project generator when using the karma-project generator directory ensure the karma generator (install deps/root config) is called if the root karma config isn't present ISSUES CLOSED: #9234
f3c8dcf
to
b2364a8
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
root karma config isn't generated when using karma-project generator
Expected Behavior
when using the karma-project generator directly ensure the karma generator (install deps/root config)
is called if the root karma config isn't present
Related Issue(s)
Fixes #9234