Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): add root karma config if one isn't present for karma-project generator #9485

Merged
merged 1 commit into from Mar 25, 2022

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Mar 23, 2022

Current Behavior

root karma config isn't generated when using karma-project generator

Note: still waiting on confirmation on a part of issue #9234 before merging

Expected Behavior

when using the karma-project generator directly ensure the karma generator (install deps/root config)
is called if the root karma config isn't present

Related Issue(s)

Fixes #9234

@nx-cloud
Copy link

nx-cloud bot commented Mar 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b2364a8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/DCmSr2us3LG4AotCnDzvnArjXD5F
✅ Preview: https://nx-dev-git-fix-karma-project-config-nrwl.vercel.app

@barbados-clemens barbados-clemens self-assigned this Mar 23, 2022
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Mar 23, 2022
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

…arma-project generator

when using the karma-project generator directory ensure the karma generator (install deps/root
config) is called if the root karma config isn't present

ISSUES CLOSED: #9234
@barbados-clemens barbados-clemens enabled auto-merge (squash) March 25, 2022 20:46
@barbados-clemens barbados-clemens merged commit c12a647 into master Mar 25, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
…arma-project generator (nrwl#9485)

when using the karma-project generator directory ensure the karma generator (install deps/root
config) is called if the root karma config isn't present

ISSUES CLOSED: nrwl#9234
@FrozenPandaz FrozenPandaz deleted the fix/karma-project-config branch June 7, 2022 23:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/angular:karma-project does not get config properly
2 participants